Skip to content

Conversation

@fluidnumerics-joe
Copy link
Contributor

This PR adds a method to create a fieldset from a UXArray.UxDataset. This new fieldset.from_fesom2 method follows similar implementation patterns in comparison to from_copernicusmarine. Standard variable names for the velocity fields are renamed to U, V, and W, and the presence (or lack of) of W is used to determine whether to create UV or UVW vector field.

Add single test for stommel gyre generic dataset
We don't want to provide this convenience here, due to the fact that
some variable placements are not supported (e.g. on an edge), but we
don't want to prevent someone who is building a new interpolator from
leveraging this new from_fesom2 method.
    We don't want to provide this convenience here, due to the fact that
    some variable placements are not supported (e.g. on an edge), but we
    don't want to prevent someone who is building a new interpolator from
    leveraging this new from_fesom2 method.
@erikvansebille
Copy link
Member

Can we add any logic/convenience on guessing Interpolators for FESOM2? Because now they are not set at all, which means that a pset.execute() will fall back to the default interpolate for UXGrids?

If it's really up to the user how to interpolate, perhaps add a keyword argument (with a sensible default)?

Or can we at least provide a warning that the user still needs to set Interpolators?

@fluidnumerics-joe
Copy link
Contributor Author

fluidnumerics-joe commented Oct 9, 2025

I ended up removing the interpolator assignment in the last commit.

We don't want to provide this convenience here, due to the fact that some variable placements are not supported (e.g. on an edge), but we don't want to prevent someone who is building a new interpolator from leveraging this new from_fesom2 method.

Some datasets, like the ones we've been working with, have variables that are on multiple locations (e.g. faces and nodes), so having a single argument for interpolation wouldn't cover all cases for a dataset.

I'll get an issue open for adding the other basic interpolator methods and adding this functionality to from_fesom2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants