-
Notifications
You must be signed in to change notification settings - Fork 164
Add method to import from fesom2 #2319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v4-dev
Are you sure you want to change the base?
Conversation
Add single test for stommel gyre generic dataset
We don't want to provide this convenience here, due to the fact that some variable placements are not supported (e.g. on an edge), but we don't want to prevent someone who is building a new interpolator from leveraging this new from_fesom2 method.
We don't want to provide this convenience here, due to the fact that
some variable placements are not supported (e.g. on an edge), but we
don't want to prevent someone who is building a new interpolator from
leveraging this new from_fesom2 method.
|
Can we add any logic/convenience on guessing Interpolators for FESOM2? Because now they are not set at all, which means that a If it's really up to the user how to interpolate, perhaps add a keyword argument (with a sensible default)? Or can we at least provide a warning that the user still needs to set Interpolators? |
|
I ended up removing the interpolator assignment in the last commit. We don't want to provide this convenience here, due to the fact that some variable placements are not supported (e.g. on an edge), but we don't want to prevent someone who is building a new interpolator from leveraging this new from_fesom2 method. Some datasets, like the ones we've been working with, have variables that are on multiple locations (e.g. faces and nodes), so having a single argument for interpolation wouldn't cover all cases for a dataset. I'll get an issue open for adding the other basic interpolator methods and adding this functionality to from_fesom2. |
Co-authored-by: Erik van Sebille <[email protected]>
This PR adds a method to create a fieldset from a
UXArray.UxDataset. This newfieldset.from_fesom2method follows similar implementation patterns in comparison tofrom_copernicusmarine. Standard variable names for the velocity fields are renamed toU,V, andW, and the presence (or lack of) ofWis used to determine whether to createUVorUVWvector field.